Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/units_from_session #22

Merged
merged 7 commits into from
Apr 26, 2024
Merged

feat/units_from_session #22

merged 7 commits into from
Apr 26, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Apr 21, 2024 •
edited
Loading

  • drop the old "ui" folder to avoid warning logs
  • session/hivemind compatible units 🎉
  • ensure wolfram gets "metric"/"nonmetric" as units per the api docs
  • disable cache, backend client does it's own caching and respects units (solver plugins ignore context when caching)
    d = WolframAlphaSkill(bus=FakeBus(), skill_id="fake.wolf")

    print(d.ask_the_wolf("what is the speed of light", units="nonmetric"))  # SI units regardless
    # The speed of light has a value of about 300 million meters per second
    print(d.ask_the_wolf("how tall is the eiffel tower", units="metric"))
    print(d.ask_the_wolf("how tall is the eiffel tower", units="nonmetric"))
    # The total height of the Eiffel Tower is 330 meters
    # The total height of the Eiffel Tower is about 1083 feet

JarbasAl added 2 commits April 9, 2024 01:24
@JarbasAl
refactor/ui->qt5
275ca88 
drop the old "ui" folder to avoid warning logs
@JarbasAl
feat/units_from_session
a84eb19
@JarbasAl JarbasAl added the enhancement New feature or request label Apr 21, 2024
@JarbasAl JarbasAl requested review from goldyfruit and a team April 21, 2024 02:50
mikejgray
mikejgray requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, please consider a separate issue to add tests

Also, the update to requirements.txt means that this skill will not run on ovos-utils==0.0.38. Is there an expectation that 0.0.38 will run on ovos-core 0.0.8?

__init__.py Outdated Show resolved Hide resolved
__init__.py Outdated Show resolved Hide resolved
@mikejgray
Copy link
Contributor

Tests are failing too, looks like some tweaks needed before they'll run

@JarbasAl JarbasAl merged commit fad09bb into dev Apr 26, 2024
1 of 9 checks passed
@JarbasAl JarbasAl deleted the feat/units_from_session branch April 26, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikejgray mikejgray mikejgray requested changes

@goldyfruit goldyfruit Awaiting requested review from goldyfruit

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JarbasAl @mikejgray